Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: more authorised token for annotations #780

Merged
merged 1 commit into from
Jul 10, 2024
Merged

github: more authorised token for annotations #780

merged 1 commit into from
Jul 10, 2024

Conversation

lsf37
Copy link
Member

@lsf37 lsf37 commented Jul 9, 2024

GITHUB_TOKEN only has read access when triggered from a fork on the pull_request trigger, so we use pull_request_target instead. This requires passing in the PR number explicitly to the thylint action.

Requires seL4/ci-actions#354 to be merged before we can test it.

@lsf37 lsf37 force-pushed the annotations branch 2 times, most recently from c2706c5 to 7b64076 Compare July 9, 2024 06:09
@lsf37 lsf37 requested a review from corlewis July 9, 2024 06:12
@lsf37 lsf37 added the CI continuous integration and testing label Jul 9, 2024
@lsf37 lsf37 self-assigned this Jul 9, 2024
Copy link
Member

@corlewis corlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I guess we'll see if it works when the other PR is merged.

.github/workflows/lint.yml Outdated Show resolved Hide resolved
@lsf37
Copy link
Member Author

lsf37 commented Jul 9, 2024

Ok, getting there. #786 has come from my fork and produced an annotation now. Still need to merge seL4/ci-actions#355 first.

GITHUB_TOKEN only has read access when triggered from a fork on the
pull_request trigger.

Signed-off-by: Gerwin Klein <[email protected]>
@lsf37 lsf37 merged commit c33ec1f into master Jul 10, 2024
7 of 12 checks passed
@lsf37 lsf37 deleted the annotations branch July 10, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants